Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

st.experimental_get_query_params is deprecated, we need to update to st.query_params #56

Closed
marcosberghahn opened this issue Feb 14, 2024 · 12 comments · Fixed by #66
Closed

Comments

@marcosberghahn
Copy link
Contributor

Hello everyone,
st.experimental_get_query_params is deprecated, we need to update to st.query_params.

Old Docs: https://docs.streamlit.io/library/api-reference/utilities/st.experimental_get_query_params
New Docs:https://docs.streamlit.io/library/api-reference/utilities/st.query_params

query_params = st.experimental_get_query_params()

@aryaneelshivam
Copy link

Yes, I was about to raise the same issue

@tylerjrichards
Copy link
Owner

hey all, thanks for the note! st paywall is on an older streamlit version, so when I update it i'll require streamlit >= 1.31 or something like that

@marcosberghahn
Copy link
Contributor Author

marcosberghahn commented Feb 21, 2024

Yes, that's the Idea, I'm already on 1.31, so I'm getting these notifications here.
Screenshot 2024-02-21 at 10 37 18
I was able to disable them for prod environment, but since I have other features that also use query params, I can't update them until st-paywall is updated as well. Otherwise Streamlit yells at me, saying I can't use the old and the new at the same time.
I definitely would submit a PR to help on this, but my "junior skills" prevented me to make this one work 😀.
So If someone could help and submit a PR, I will be a very grateful pal, one beer on me next time we meet.

@AbdielWillyar
Copy link

hi, same issues. but i try to find the code and try to replace the old version,
but i think the author for this library must update, so the library not show conflict in future

@tobibuchmann
Copy link

Hi, I installed st-paywall from github and testet with different versions of streamlit, but I always get:

Please replace st.experimental_get_query_params with st.query_params.

st.experimental_get_query_params will be removed after 2024-04-11.

Refer to our docs page for more information.

@hahnsangkim
Copy link

Line 84 in google_auth.py
Replacing
query_params = st.experimental_get_query_params()
by
query_params = st.query_params
will work out fine.

@j-bull2003
Copy link

Please fix this issue!

@tylerjrichards
Copy link
Owner

this is fixed in 0.1.7! let me know if it works for you all

@j-bull2003
Copy link

Hey there, now strangely I am getting this error: TypeError: QueryParamsProxy.get_all() missing 1 required positional argument: 'key' - does anyone else have this issue?

@tylerjrichards
Copy link
Owner

I merged @blackary's PR and tested it this morning, while I was testing the first PR I was actually was testing it on the wrong version of st-paywall. This should rectify! 0.1.8 should be better.

@j-bull2003
Copy link

Thanks! However, I am still getting this Type error: TypeError: QueryParamsProxy.get_all() missing 1 required positional argument: 'key'

@sfc-gh-zblackwood
Copy link

Hi @j-bull2003 can you double-check that you're installing and running 0.1.8? That function is no longer used in the code for 0.1.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants