Skip to content
This repository has been archived by the owner on Sep 22, 2020. It is now read-only.

get has wrong type signature #2

Closed
scubamaggo opened this issue Mar 6, 2017 · 4 comments
Closed

get has wrong type signature #2

scubamaggo opened this issue Mar 6, 2017 · 4 comments

Comments

@scubamaggo
Copy link

The get function seems to have the wrong signature. The readme specifies it correctly as
get<K, V>(key: K, map: HashMap<K, V>): V | null

while the implementation actually has
get<K, V>(key: K, map: HashMap<K, V>): K | null

@TylorS
Copy link
Owner

TylorS commented Mar 7, 2017

Yes, you're totally correct. I'll get a fix out soon

@cbyad
Copy link

cbyad commented Oct 29, 2018

This issue haven't been fixed . we get the same signature !! :-(

get<K, V>(key: K, map: HashMap<K, V>): K | null;
get<K, V>(key: K): (map: HashMap<K, V>) => K | null;

@TylorS
Copy link
Owner

TylorS commented Oct 29, 2018

Hey @cbyad This package is actually not maintained. If you're in need of a hashmap, the work here was built on and improved here with a great maintainer https://github.com/frptools/collectable

@cbyad
Copy link

cbyad commented Oct 29, 2018

@TylorS Thanks. I used basic ES6 Map instead .
I'll check for more complex operations and immutable state.

@TylorS TylorS closed this as completed Sep 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants