Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Drag handle test snapshot is incorrect for Firefox #48

Closed
matthewlipski opened this issue Oct 21, 2022 · 2 comments
Closed

Bug: Drag handle test snapshot is incorrect for Firefox #48

matthewlipski opened this issue Oct 21, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@matthewlipski
Copy link
Collaborator

One of the tests for the drag handle involves creating a heading using the slash menu, then adding another through the drag handle:

test("Clicking add button should create new block", async () => {
  await executeSlashCommand(page, "h1");
  await page.keyboard.type("Hover over this text");
  await hoverAndAddBlockFromDragHandle(page, H_ONE_BLOCK_SELECTOR, "h2");
  await page.keyboard.type("This is an h2");
  await page.waitForSelector(H_TWO_BLOCK_SELECTOR);

  await page.waitForTimeout(1000);
  await compareDocToSnapshot(page, "draghandleadd");
});

However, running the test on Firefox adds an empty nested paragraph to the second heading, as can be seen when comparing the Firefox, Chromium, and Webkit snapshots. Since the reference snapshot includes this bug, the test still passes, though this should be changed such that Firefox behaviour is the same as Chromium and Webkit,

@matthewlipski matthewlipski added the bug Something isn't working label Oct 21, 2022
@matthewlipski
Copy link
Collaborator Author

A possibly related issue also arises for block drag & drop tests, for which Firefox behaviour is also drastically different to Chromium and Webkit.

@YousefED
Copy link
Collaborator

afaik this is documented in the codebase. It doesn't cause critical end-user bugs and tests on chromium still work.

Closing in favor of a cleaned backlog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants