Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getting blocknote compile error in sublime text 3 but not webpack #898

Closed
1 task
HenrikBechmann opened this issue Jul 2, 2024 · 1 comment · Fixed by #923
Closed
1 task

getting blocknote compile error in sublime text 3 but not webpack #898

HenrikBechmann opened this issue Jul 2, 2024 · 1 comment · Fixed by #923
Labels
bug Something isn't working

Comments

@HenrikBechmann
Copy link

HenrikBechmann commented Jul 2, 2024

Describe the bug
<what's going wrong!?>
When I run build in sublime text 3, with nothing more than the following references to Blocknote...

import "@blocknote/core/fonts/inter.css";
import { useCreateBlockNote } from "@blocknote/react";
import { BlockNoteView } from "@blocknote/mantine";
import "@blocknote/mantine/style.css";

...I get the following error

../../../../node_modules/@blocknote/core/types/src/editor/BlockNoteTipTapEditor.d.ts(13,22): error TS2415: Class 'BlockNoteTipTapEditor' incorrectly extends base class 'Editor'.
  Property 'createView' is private in type 'Editor' but not in type 'BlockNoteTipTapEditor'.

However, compiling with webpack (dev) completes without error.

using

    "@blocknote/core": "^0.14.2",
    "@blocknote/mantine": "^0.14.2",
    "@blocknote/react": "^0.14.2",

and sublime text 3 build 4169

See #921

To Reproduce
<clear steps to reproduce are super helpful! Best is to provide an online sandbox, click to create one>

Misc

  • Node version: 20.5.1
  • Package manager: webpack 5.92.1
  • Browser: chrome 126.0.6478.127
  • I'm a sponsor and would appreciate if you could look into this sooner than later 💖
@HenrikBechmann HenrikBechmann added the bug Something isn't working label Jul 2, 2024
@HenrikBechmann
Copy link
Author

Looks like sublime is using typescript 5.4.5, whereas webpack ts-loader is using typescript 5.2.2. So I presume sublime is catching the error correctly. Meaning webpack will catch this error eventually, which means I can't use BlockNote until this is fixed.

Also the error

../../../../node_modules/@blocknote/core/types/src/editor/BlockNoteTipTapEditor.d.ts(13,22): error TS2415: Class 'BlockNoteTipTapEditor' incorrectly extends base class 'Editor'.
  Property 'createView' is private in type 'Editor' but not in type 'BlockNoteTipTapEditor'.

looks legitimate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant