Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic Token Scopes not provided #601

Open
evoactivity opened this issue Jul 10, 2023 · 2 comments
Open

Semantic Token Scopes not provided #601

evoactivity opened this issue Jul 10, 2023 · 2 comments

Comments

@evoactivity
Copy link
Contributor

Semantic tokens add additional syntax highlighting for things like decorators etc.

Also tracking in chiragpat/vscode-glimmer#14

When this is used with vscode-glimmer, I don't think the language server provides the semanticTokenScopes required to apply the correct colours ontop of the syntax highlighting.

Typescript Language Server provides semantic tokens here https://github.com/microsoft/vscode/blob/main/extensions/typescript-language-features/src/languageFeatures/semanticTokens.ts

Incorrect Correct
image image
image image
@evoactivity evoactivity changed the title Semantic Tokens Scopes not provided Semantic Token Scopes not provided Jul 10, 2023
@evoactivity
Copy link
Contributor Author

Actually not sure if this would be a glint concern or an ember language server concern.

I'm tracking an issue related to code folding on ELS here lifeart/vscode-ember#43 and if the fix for code folding is for ELS to provide JS/TS folding, the fix for semantic tokens might also be to add it to ELS.

Since the typescript language server is not running for a glimmer-ts or glimmer-js files one of the projects will need to fill in the missing features but I'm not sure which project is the right one.

@NullVoxPopuli
Copy link
Contributor

I think adding semantic folding here makes sense as well, at the very least for the js/ts stuff.

To do the in-<template>-tag folding, we'd need to also produce an AST for for the things within the template, which I know @patricklx has been playing with in other tools (eslint)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants