Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[etlas] Support WAR file generation #265

Closed
rahulmutt opened this issue Apr 7, 2017 · 4 comments
Closed

[etlas] Support WAR file generation #265

rahulmutt opened this issue Apr 7, 2017 · 4 comments
Labels

Comments

@rahulmutt
Copy link
Member

  1. The special resources directory should be recognised by etlas and it should package them up into a JAR for static resources WEB-INF, META-INF, *.html, *.css files.
  2. When building a project, all the dependency jars should be copied into the lib/ folder of the WAR file.

etlas configure --generate-war

@rahulmutt rahulmutt added the build label Apr 7, 2017
@jneira
Copy link
Collaborator

jneira commented Apr 8, 2017

Good one! it will do web app devlopment with eta more agile and comfortable.
To have a reference, other build tools in jvm ecosystem usually do:

  • put the compiled code and other resources that have to be in the classpath (config files f.e.) in WEB-INF\classes without packaging it
    • maybe etlas could handle it as a dependency
  • by default they copy the app dependencies int WEB-INF\lib
    • although you usually can avoid it with a option: --no-jars or alike
    • it's common in some envs to handle dependencies (part of all of them) outside the app, at server level
  • copy the content of resources (maybe configurable in cabal file) in the root of the war package
    • i suppose web.xml would be in that dir
  • they can create the flat war structure in dist to let the user config the server to use that location directly to serve the app, instead of have to make the war in each compile step

@Jyothsnasrinivas
Copy link
Member

This can be easily done with the Gradle plugin. @jneira Do you still think it's a good idea to keep it inside of etlas?

@jneira
Copy link
Collaborator

jneira commented Jul 8, 2018

@Jyothsnasrinivas yeah, gradle seems to be the correct tool for this

@Jyothsnasrinivas
Copy link
Member

@jneira In that case I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants