Skip to content
This repository has been archived by the owner on Feb 8, 2022. It is now read-only.

Band is specialized on too much #90

Closed
johnynek opened this issue Oct 8, 2015 · 2 comments · Fixed by #96
Closed

Band is specialized on too much #90

johnynek opened this issue Oct 8, 2015 · 2 comments · Fixed by #96

Comments

@johnynek
Copy link
Contributor

johnynek commented Oct 8, 2015

https://github.com/non/algebra/blob/master/core/src/main/scala/algebra/Band.scala#L10

we restricted later (to avoid code bloat) to Int, Long, Float, Double. Looks like we missed it on band. What should we do?

Dropping it will break binary compatibility, so we should decide soon. It would be nice to have a way to set this in one place or an easy way to grep for the specializations. There may be others we missed.

@tixxit
Copy link
Contributor

tixxit commented Oct 8, 2015

Is now the time to set our policy regarding versioning and breaking binary compatibility? Is it fair to say that until we are 1.0, any minor version change may break binary compatilibity? For example, this change would be accepted in 0.4.0, but not 0.3.2.

@johnynek
Copy link
Contributor Author

johnynek commented Oct 9, 2015

I would agree with fixing this in 0.4.0 (semver 0 prefix is kind of anything goes).

That said, especially for core, it would be good if that could reach 1.0.0 somewhat soonish.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants