Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request release to support Scala Native 0.5.0 #294

Closed
ekrich opened this issue Apr 28, 2024 · 5 comments
Closed

Request release to support Scala Native 0.5.0 #294

ekrich opened this issue Apr 28, 2024 · 5 comments

Comments

@ekrich
Copy link
Contributor

ekrich commented Apr 28, 2024

I believe this is s blocker for Cats typelevel/cats#4587.

Thanks, this would free up a bunch of downstream once Cats is ready.

@satorg
Copy link
Contributor

satorg commented Apr 28, 2024

The current version is 2.0.0-M3.
But since MUnit went 1.0.0-RC1, does it make sense for discipline-munit to release its RC1 too?

@ekrich
Copy link
Contributor Author

ekrich commented Apr 29, 2024

Makes sense to me but I am not sure about the versioning scheme.

@TonioGela
Copy link
Member

TonioGela commented Apr 29, 2024

Makes sense to me but I am not sure about the versioning scheme.

There's support in sbt-tl for RC versions: https://typelevel.org/sbt-typelevel/faq.html

Thinking out loud: if we begin following the munit versioning scheme we won't be able (at least not with the same ease) to release in case of bugs or dep bumps, and we would tie our version with the munit one.

I'll probably name this release 2.0.0-M4 and I'll, release 2.0.0 once we get munit 1.0.0. WDYT?

tagging @armanbilge as he's the wisest among all of us

@djspiewak
Copy link
Member

With respect to semver, the constraint I tend to follow is that you shouldn't imply a degree of version stability which is stricter than what your upstream provides. So if the upstream is on an RC, you shouldn't release an untagged version. However, if your upstream is an RC, there's no reason you shouldn't be allowed to release an M. So in other words, I'm aligned with your plan!

@TonioGela
Copy link
Member

Here's the release: https://github.com/typelevel/discipline-munit/releases/tag/v2.0.0-M4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants