Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross compile with the full Scala version #15

Closed
dragos opened this issue Jun 24, 2015 · 5 comments
Closed

Cross compile with the full Scala version #15

dragos opened this issue Jun 24, 2015 · 5 comments

Comments

@dragos
Copy link

dragos commented Jun 24, 2015

I wonder why kind-projector is cross compiled using only the major Scala version. AFAIK compiler plugins can access compiler internals, therefore are not subject to any binary compatibility guarantees between (any two) releases.

@non
Copy link
Contributor

non commented Jul 4, 2015

Hi @dragos, sorry I only just saw this issue.

It's a good point. So far we haven't had any problems but you're right, the code could change.

I'll look into publishing against the full version.

@SethTisue
Copy link
Member

well, lucky so far :-)

@SethTisue
Copy link
Member

SethTisue commented May 30, 2019

to expand on that,

we do normally recommend that compiler plugins be published against the full Scala version.

however, kind-projector is an unusual plugin, in that it runs very early during compilation. that part of the Scala compiler rarely changes.

and, using the Scala version would mean additional publishing hassle since it would have to be republished for every Scala minor version, and kind-projector is so basic in the Scala library ecosystem that any delay would be felt downstream, as well.

so on the balance, I think the status quo is okay.

if a Scala version ever comes out that breaks the plugin, it will almost certainly cause compile-time problems that users' CI will catch (rather than expensive runtime issues), and we can rush out a new plugin version that fixes the problem.

@xuwei-k
Copy link
Contributor

xuwei-k commented Sep 18, 2019

#117

@larsrh
Copy link
Contributor

larsrh commented Oct 3, 2019

Closed by #119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants