Reduce exposure of end methods for spans
#350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce the exposure of `end` methods for spans by creating a separate `Span.Manual` type returned only by `SpanOps#startUnmanaged` that contains the `end` methods and removing the `end` methods from `Span`. Neither type inherits from the other, so `Span.Manual` instances must be explicitly converted to `Span` instances for use in general operations.
|
I decided to push up a PR for this both because I'd already written it and to show how little it changes user code (as evidenced by the lack of test changes). folks can chime in whether they think the API changes are invasive and/or worth it |
NthPortal
commented
Oct 30, 2023
| extends SpanAPI[F] { | ||
|
|
||
| /** This span, without the ability to end it. */ | ||
| lazy val unmanageable: Span[F] = Span.fromBackend(backend) |
There was a problem hiding this comment.
this name feels kind of silly, but I can't think of anything better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the exposure of
endmethods for spans by creating a separateSpan.Manualtype returned only bySpanOps#startUnmanagedthat contains theendmethods and removing theendmethods fromSpan. Neither type inherits from the other, soSpan.Manualinstances must be explicitly converted toSpaninstances for use in general operations.Resolves #347