Test With SwiftCheck #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just tell me when you're satisfied with it, and I'll take a look. :) |
|
There, better. See prisms comments for limitations. I've been thinking of just composing on some non-deterministic A -> A? then I realized that kinda defeats the purpose of the Iso! I can always come back to this when I relax the constraints on ArrowOf.... Actually 💡 |
|
Okay, I feel better now. Ready for review. |
| @@ -6,52 +6,6 @@ | |||
| // Copyright © 2015 TypeLift. All rights reserved. | |||
| // | |||
|
|
|||
| /// Compose | Applies one function to the result of another function to produce a third function. | |||
There was a problem hiding this comment.
This eases my fears about operator clashing forever now.
|
Welp, shipping now. ⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am thoroughly disappointed with the way this turned out. I need to think a bit more about how to generate inverse functions with SwiftCheck before this gets merged.