Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix pageScroll #474

Merged
merged 11 commits into from
Jan 2, 2023
Merged

fix(app): fix pageScroll #474

merged 11 commits into from
Jan 2, 2023

Conversation

grzegorzpokorski
Copy link
Member

PR resolve #463 issue.

@vercel
Copy link

vercel bot commented Jan 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
devfaq ✅ Ready (Inspect) Visit Preview Jan 2, 2023 at 8:07PM (UTC)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
mobile https://devfaq-iiz21fhf8-typeofweb.vercel.app

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

@github-actions
Copy link

github-actions bot commented Jan 1, 2023

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 79.77 KB (🟡 +2 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@grzegorzpokorski
Copy link
Member Author

grzegorzpokorski commented Jan 1, 2023

Dodałem customową klasę CSS do ukrywania pasków przewijania oraz dodałem propsa do funkcji w lockScroll.ts, aby rozróżnić jaki rodzaj blokowania przewijania strony jest wymagany w danym przypadku ze względu na szerokość viewportu. Całość w efekcie daje możliwość blokowania pasków przewijania bez konfliktów z klasami CSS, które są dodawane / usuwane przez funkcje z lockScroll.ts.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
mobile https://devfaq-hlcwoea83-typeofweb.vercel.app

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

@grzegorzpokorski
Copy link
Member Author

grzegorzpokorski commented Jan 2, 2023

Dodałem customową klasę CSS do ukrywania pasków przewijania oraz dodałem propsa do funkcji w lockScroll.ts, aby rozróżnić jaki rodzaj blokowania przewijania strony jest wymagany w danym przypadku ze względu na szerokość viewportu. Całość w efekcie daje możliwość blokowania pasków przewijania bez konfliktów z klasami CSS, które są dodawane / usuwane przez funkcje z lockScroll.ts.

Generalnie chodzi o to, że otwarcie menu mobilnego lub sidebara i jednocześnie modala - co można osiągnąć zmieniając szerokość viewportu podczas, gdy mamy otwarte menu mobilne lub sidebara - nie powoduje konfliktów z dodawanymi / usuwanymi klasami CSS.

apps/app/src/styles/tailwind.css Outdated Show resolved Hide resolved
apps/app/src/utils/pageScroll.ts Outdated Show resolved Hide resolved
apps/app/src/utils/pageScroll.ts Outdated Show resolved Hide resolved
apps/app/src/utils/pageScroll.ts Outdated Show resolved Hide resolved
apps/app/src/utils/pageScroll.ts Outdated Show resolved Hide resolved
grzegorzpokorski and others added 2 commits January 2, 2023 18:21
Co-authored-by: Michał Miszczyszyn <michal@mmiszy.pl>
Co-authored-by: Michał Miszczyszyn <michal@mmiszy.pl>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
mobile https://devfaq-lcc4nmic2-typeofweb.vercel.app

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
mobile https://devfaq-oqw48qs2s-typeofweb.vercel.app

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

grzegorzpokorski and others added 2 commits January 2, 2023 20:35
Co-authored-by: Michał Miszczyszyn <michal@mmiszy.pl>
Co-authored-by: Michał Miszczyszyn <michal@mmiszy.pl>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
mobile https://devfaq-gkveohw40-typeofweb.vercel.app

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

@typeofweb typeofweb merged commit e5672da into develop Jan 2, 2023
@typeofweb typeofweb deleted the fix-pageScroll branch January 2, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Locked page scrolling when switch from vertical to horizontal mode
2 participants