Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ioredis/cluster 2nd(options) parameter support #3538

Closed
scvgoe opened this issue Jan 29, 2019 · 3 comments
Closed

ioredis/cluster 2nd(options) parameter support #3538

scvgoe opened this issue Jan 29, 2019 · 3 comments

Comments

@scvgoe
Copy link
Contributor

scvgoe commented Jan 29, 2019

Issue type:

[ ] question
[ ] bug report
[x] feature request
[ ] documentation issue

Database system/driver:

[ ] cordova
[ ] mongodb
[ ] mssql
[ ] mysql / mariadb
[ ] oracle
[ ] postgres
[ ] sqlite
[ ] sqljs
[ ] react-native
[ ] expo

TypeORM version:

[x] latest
[ ] @next
[ ] 0.x.x (or put your version here)

Question
Hi, I appreciate your support for ioredis/cluster.

Actually, ioredis.Cluster constructor allow two parameters (startupNodes and options).
You can check them here

But I cannot inject 2nd parameter (options) to here.

Do you have any plan to fix this problem?

@scvgoe scvgoe changed the title cache option's ioredis/cluster support ioredis/cluster 2nd(options) parameter support Jan 29, 2019
@vlapo
Copy link
Contributor

vlapo commented Jan 29, 2019

ioredis and ioredis-cluster caches were thankfully provided by @HussainAliAkbar and @ignacioblit. Could you please check this issue?

Also feel free to contribute.

@HussainAliAkbar
Copy link
Contributor

Hey! sure thing. I'll check this in a while.

@Kononnable
Copy link
Contributor

I think this issue can be closed now since, PR was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants