fix(postgres): postgres query runner to create materialized view #4877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleerock
reviewed
Oct 13, 2019
| if (typeof view.expression === "string") { | ||
| return new Query(`CREATE VIEW ${this.escapePath(view)} AS ${view.expression}`); | ||
| return new Query(`CREATE ${materializedClause}VIEW "${view.name}" AS ${view.expression}`); |
There was a problem hiding this comment.
what is the point of removing this.escapePath here?
There was a problem hiding this comment.
Oops, didn't notice that! Will amend, good catch 😄
(I'll be honest, it was copy pasta from the previous PR 😉)
|
Not sure what you did in the last commit, but looks like its still not using this.escapePath |
|
@pleerock It’s pulled out to a const on line 1743 of the PostgresQueryRunner class as |
|
oh okay. Let's merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've just started using a materialized view in our project (postgres DB) and noticed that the schema sync task during our tests was not creating a materialized version of the view when passing
{ materialized: true }in the entity definition.Looks like a few things were missed in #4478:
PostgresQueryRunner.ts.MATERIALIZEDto the create view SQLmaterializedoption in the entity definition was always being set to false due to not being passed throughWe're using my fork internally in production and the new materialized views are working great. Would be awesome to have someone take a look at this 😄