Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sha.js instead of crypto for hash calculation #5270

Merged
merged 2 commits into from
Jan 2, 2020

Conversation

nochkin
Copy link
Contributor

@nochkin nochkin commented Dec 31, 2019

Initial discussion @ #5249

@Kononnable Kononnable added the regression worked in previous version and doesn't work in current label Jan 1, 2020
@pleerock pleerock merged commit b380a7f into typeorm:master Jan 2, 2020
@pleerock
Copy link
Member

pleerock commented Jan 2, 2020

Thanks guys!

@thynson
Copy link

thynson commented Jan 2, 2020

Why not use isomorphic-crypto instead, which still use native SHA implementation on node environment.

@nochkin
Copy link
Contributor Author

nochkin commented Jan 3, 2020

@thynson,
That will probably break using TypeORM in React-Native (this is how I stumbled onto this issue initially).
At least, the "sha.js" is more universal solution as it's available in other worlds too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression worked in previous version and doesn't work in current
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants