Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring instance of with Array.isArray() #5539

Merged
merged 1 commit into from
Feb 17, 2020

Conversation

naidishuli
Copy link
Contributor

This pull request is based on the content on this page: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/instanceof. This will solve and prevent troubles with typeorm functionalities when calling functions from different contexts. When using typeorm from REPL you will not be able to obtain relations of a specific entity. This PR will solve the issue.

@pleerock pleerock merged commit 1e1595e into typeorm:master Feb 17, 2020
@pleerock
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants