fix: reject nullable primary columns #7001
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every supported back-end requires that primary key columns be non-nullable.
As of this PR, this mistake is caught at compile-time rather than as part of execution.
BREAKING CHANGE: passing
ColumnOptions
to@PrimaryKeyColumn
does not function anymore. One must usePrimaryKeyColumnOptions
instead.Description of change
Forbid primary columns from being marked as nullable. This condition is expected by all currently-supported back-ends and is generally understood to be standard.
As of the time this PR was opened, some of the tests aren't passing on my machine, and I've not touched documentation. I'd like to validate that this change is desired and likely to be merged before spending more time on it.
Pull-Request Checklist
master
branchnpm run lint
passes with this changenpm run test
passes with this changeFixes #0000
(N/A)