-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export all errors #7006
feat: export all errors #7006
Conversation
f510d6e
to
0b5e2dc
Compare
@imnotjames can have this in next realease, most awaited feature for me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of exporting each of these individually in the src/index.ts
, would it be clearer to create an index.ts
in error
which iterates through them?
That way we could do export * from "./error"
and isolate the error export iteration to the error dir.
What do you think?
That's a good idea an i had it myself, i just oriented myself on the existing code to stay consistent. But of course, will do it in a second |
@imnotjames ping! |
I think this pr can be merged if there are no any alterations to be made |
Why is this not merged? It's not even hard to review :/ |
@imnotjames little help here |
There is still the unresolved conversation in #6909. Personally I think the classes should all be exported but there may be reasons not to, for example avoiding creating a public API that will later result in breaking changes if the errors are renamed. Either way it's not being ignored, pleerock has just not gotten around to all the pending pull requests and there are many others waiting too. If you need it I suggest making a local repo with the changes applied and using |
I don't think errors should be part of public API and I don't really like how errors are currently designed, but we can merge this PR if somebody needs it. |
Thank you for contribution! Please keep in mind in the future we most probably will change errors public api. |
Description of change
This PR adds the export of all errors.
Fixes #7000
Pull-Request Checklist
master
branchnpm run lint
passes with this changenpm run test
passes with this changeFixes #0000