Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MariaDB VIRTUAL [NOT NULL|NULL] error #7022

Merged
merged 2 commits into from
Feb 8, 2021
Merged

Fix MariaDB VIRTUAL [NOT NULL|NULL] error #7022

merged 2 commits into from
Feb 8, 2021

Conversation

Maczuga
Copy link
Contributor

@Maczuga Maczuga commented Nov 5, 2020

Description of change

Fixes #2691

query failed: ALTER TABLE customer CHANGE fullName fullName varchar(255) AS (CONCAT(firstName, ' ', lastName)) VIRTUAL NULL
error: Error: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'NULL' at line 1

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #2691
  • There are new or updated unit tests validating the change N/A
  • Documentation has been updated to reflect this change N/A
  • The new commits follow conventions explained in [CONTRIBUTING.md] (https://github.com/typeorm/typeorm/blob/master/CONTRIBUTING.md)

Maczuga and others added 2 commits November 5, 2020 17:46
@Maczuga
Fix MariaDB VIRTUAL [NOT NULL|NULL] error
16514c5 
Fixes #2691

query failed: ALTER TABLE `customer` CHANGE `fullName` `fullName` varchar(255) AS (CONCAT(`firstName`, ' ', `lastName`)) VIRTUAL NULL
error: Error: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'NULL' at line 1
@pleerock
slightly change code style to improve readability
88bffdd
@pleerock pleerock merged commit 82f2b75 into typeorm:master Feb 8, 2021
@pleerock
Copy link
Member

pleerock commented Feb 8, 2021

Thank you for contribution! 🎉

This was referenced Mar 15, 2021
Merged
Closed
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MariaDb VIRTUAL columns don't accept [NULL | NOT NULL]
2 participants
@Maczuga @pleerock