Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration -t Flag Documentation Missing #7168

Open
3 tasks
arnmishra opened this issue Dec 7, 2020 · 0 comments
Open
3 tasks

Migration -t Flag Documentation Missing #7168

arnmishra opened this issue Dec 7, 2020 · 0 comments

Comments

@arnmishra
Copy link

Documentation Issue

What was unclear or otherwise insufficient?

It seems like the -t flag for typeorm migrations is missing in the documentation. We found a reference to it here #1408 and were able to figure out other options (like each) by looking at the code here

switch (args.t) {
case "all":
options.transaction = "all";
break;
case "none":
case "false":
options.transaction = "none";
break;
case "each":
options.transaction = "each";
break;
default:
// noop
and here https://github.com/typeorm/typeorm/blob/master/src/migration/MigrationExecutor.ts#L23-L26. I was looking at the documentation here https://typeorm.io/#/migrations/running-and-reverting-migrations

Recommended Fix

I think we should add documentation around the different -t options and what they result in.

Are you willing to resolve this issue by submitting a Pull Request?

  • Yes, I have the time, and I know how to start.
  • Yes, I have the time, but I don't know how to start. I would need guidance.
  • [ x] No, I don't have the time, although I believe I could do it if I had the time...
  • No, I don't have the time and I wouldn't even know how to start.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant