fix: datetime2 rounding in mssql #7264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contribution! Are these changes backward compatible with previous mssql package versions? |
Yes, the test suite doesn't pass without modification for To test this with version 6 I needed to update a few tests.
But given the above modifications it all passes with this PR and no change to the |
|
I also double checked the v6 JSDoc typing and that also states a string. https://github.com/tediousjs/node-mssql/blob/375419b590036bb8566bfc4452caa18b2ed444cd/lib/base/request.js#L100 And the same for v5 So it seems it should have always been a string but never actually mattered until now |
|
@pleerock do you need anything more or are you waiting for v7 to be fully released? |
|
I can confirm that we followed the same update path in our project to fix the same bug and have encountered the same error. Thank you @tgandrews |
This upgrades the `mssql` driver to version 7 to resolve #3202. This issue was created in the bulk insert test adding a datetime2 field with a time of midnight. v7 no longer allows numeric parameter names and was throwing an error inside tedious but you can see that `node-mssql` is expecting a string. https://github.com/tediousjs/node-mssql/blob/76585f973dd8cad48836fe302f99f67d47ff6129/lib/base/request.js#L101 Another user saw this issue in the comments of issue #3202. #3202 (comment) Stringifying the numeric parameter names before it enters the driver resolves this issue. Now all mssql tests pass locally once you provide additional config in `ormconfig.json` locally required for a locally running docker instance of mssql which uses a self signed certificate. ```json "extra": { "trustServerCertificate": true } ```
|
This has been bumped to |
|
thank you for contribution! |
This was referenced Mar 15, 2021
v1d3rm3
pushed a commit
to v1d3rm3/typeorm
that referenced
this pull request
Jun 30, 2021
This upgrades the `mssql` driver to version 7 to resolve typeorm#3202. This issue was created in the bulk insert test adding a datetime2 field with a time of midnight. v7 no longer allows numeric parameter names and was throwing an error inside tedious but you can see that `node-mssql` is expecting a string. https://github.com/tediousjs/node-mssql/blob/76585f973dd8cad48836fe302f99f67d47ff6129/lib/base/request.js#L101 Another user saw this issue in the comments of issue typeorm#3202. typeorm#3202 (comment) Stringifying the numeric parameter names before it enters the driver resolves this issue. Now all mssql tests pass locally once you provide additional config in `ormconfig.json` locally required for a locally running docker instance of mssql which uses a self signed certificate. ```json "extra": { "trustServerCertificate": true } ``` (cherry picked from commit 4711a71)
zshipleyTAG
pushed a commit
to Amherst-Development/typeorm
that referenced
this pull request
Oct 17, 2022
This upgrades the `mssql` driver to version 7 to resolve typeorm#3202. This issue was created in the bulk insert test adding a datetime2 field with a time of midnight. v7 no longer allows numeric parameter names and was throwing an error inside tedious but you can see that `node-mssql` is expecting a string. https://github.com/tediousjs/node-mssql/blob/76585f973dd8cad48836fe302f99f67d47ff6129/lib/base/request.js#L101 Another user saw this issue in the comments of issue typeorm#3202. typeorm#3202 (comment) Stringifying the numeric parameter names before it enters the driver resolves this issue. Now all mssql tests pass locally once you provide additional config in `ormconfig.json` locally required for a locally running docker instance of mssql which uses a self signed certificate. ```json "extra": { "trustServerCertificate": true } ```
afriedrichTAG
added a commit
to Amherst-Development/typeorm
that referenced
this pull request
Oct 18, 2022
fix: datetime2 rounding in mssql (typeorm#7264)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This upgrades the
mssqldriver to version 7 to resolve #3202. Thisissue was created in the bulk insert test adding a datetime2 field
with a time of midnight.
v7 no longer allows numeric parameter names and was throwing an error
inside tedious but you can see that
node-mssqlis expecting a string.https://github.com/tediousjs/node-mssql/blob/76585f973dd8cad48836fe302f99f67d47ff6129/lib/base/request.js#L101
Another user saw this issue in the comments of issue #3202.
#3202 (comment)
Stringifying the numeric parameter names before it enters the driver
resolves this issue.
Now all mssql tests pass locally once you provide additional config in
ormconfig.jsonlocally required for a locally running docker instanceof mssql which uses a self signed certificate.
Pull-Request Checklist
masterbranchnpm run lintpasses with this changenpm run testpasses with this changeFixes #0000