useUTC for oracle and postgres #7295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If useUTC is set to true, then for Oracle set environment variable 'ORA_SDTZ' and for postgres set ''PGTZ'
|
Thank you for contribution! |
silentroach
reviewed
Feb 9, 2021
| @@ -16,6 +16,11 @@ export interface OracleConnectionOptions extends BaseConnectionOptions, OracleCo | |||
| */ | |||
| readonly schema?: string; | |||
|
|
|||
| /** | |||
| * A boolean determining whether to pass time values in UTC or local time. (default: true). | |||
There was a problem hiding this comment.
isn't it a breaking change?
There was a problem hiding this comment.
there is no code in this PR where this option is set to true explicitly. Maybe comment is just wrong @Alankarsharma ?
There was a problem hiding this comment.
this is part of connection options. If user set this value to true in that case I am setting those environment variables.
There was a problem hiding this comment.
Default behaviour is false, so anyone who is using this for oracle or Postgres will not face any issue.
There was a problem hiding this comment.
so it will be great to change comments and documentation
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If useUTC is set to true, then for Oracle set environment variable 'ORA_SDTZ' and for postgres set 'PGTZ'.
Based on documentation I thought 'useUTC' was used for all databases, but it was actually set only for MSSQL.
If this option is set to true then I am setting environment variables for oracle and Postgres.
Description of change
Pull-Request Checklist
masterbranchnpm run lintpasses with this changenpm run testpasses with this changeFixes #0000