Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save does not return id, save does not return generated #7336

Merged
merged 9 commits into from
Feb 6, 2021
Merged

fix: save does not return id, save does not return generated #7336

merged 9 commits into from
Feb 6, 2021

Conversation

TheBlue-1
Copy link
Contributor

@TheBlue-1 TheBlue-1 commented Feb 2, 2021

Description of change

Generated fields got overridden by undefined in the entity returned by save, if there are one to many relations in the entity.
I changed this, so the generated fields get merged and not overriden.
Fixes #5520
Fixes #2422
Fixes #4090

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • [not needed] Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@pleerock
Copy link
Member

pleerock commented Feb 2, 2021

Thank you for contribution! Can you please include tests to this PR?

@Berbass
Copy link

Berbass commented Feb 3, 2021

Hey,
This fix will save my life!

Will it be merged soon?

@pleerock pleerock merged commit 01a6aee into typeorm:master Feb 6, 2021
@pleerock
Copy link
Member

pleerock commented Feb 6, 2021

Thank you for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants