Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issue-7065): append condition to STI child entity join #7339

Merged
merged 1 commit into from
Feb 6, 2021
Merged

fix(issue-7065): append condition to STI child entity join #7339

merged 1 commit into from
Feb 6, 2021

Conversation

yohannpoli
Copy link
Contributor

@yohannpoli yohannpoli commented Feb 4, 2021

Description of change

Add discriminator condition on JOIN statement for child entity of STI.

Fixes #7065
Fixes #3181

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • [not needed] Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@yohannpoli yohannpoli changed the title fix(issue-7065): append condition to STI child entity join wip: fix(issue-7065): append condition to STI child entity join Feb 4, 2021
@yohannpoli yohannpoli changed the title wip: fix(issue-7065): append condition to STI child entity join fix(issue-7065): append condition to STI child entity join Feb 4, 2021
@pleerock pleerock merged commit 68bb82e into typeorm:master Feb 6, 2021
@pleerock
Copy link
Member

pleerock commented Feb 6, 2021

Thank you for contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants