Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relationLoader: load with existing queryRunner #7471

Merged
merged 6 commits into from
Mar 29, 2021
Merged

relationLoader: load with existing queryRunner #7471

merged 6 commits into from
Mar 29, 2021

Conversation

michaelschoenbaechler
Copy link
Contributor

@michaelschoenbaechler michaelschoenbaechler commented Mar 15, 2021 •
edited
Loading

Description of change

Pass queryRunner in order to use existing transaction. Since testing is not complete, changes can not be merged yet.

Todo:

  • Find a way to test which connection from connection pool is used

Fixes: #5338

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@michaelschoenbaechler
fix: pass queryRunner
c2a48f6 
pass queryRunner in order to use existing transaction

Closes: #5338
@michaelschoenbaechler
test: add basic test
34a1427 
add unfinished basic test with explanation to reproduce bahavior
@michaelschoenbaechler
test: remove only flag
f431b55
@michaelschoenbaechler
test: remove only flag
7530d9d
@michaelschoenbaechler michaelschoenbaechler changed the title load many with existing query runner loadMany with existing query runner Mar 15, 2021
@michaelschoenbaechler michaelschoenbaechler changed the title loadMany with existing query runner relationLoader: load with existing queryRunner Mar 15, 2021
@michaelschoenbaechler michaelschoenbaechler marked this pull request as draft March 15, 2021 17:31
@michaelschoenbaechler
test: remove logging
e5aea25 
remove logging when acquiring connection
@lukinet
test: automate transaction-load-many
357438b 
automate transaction-load-many for postgres, mysql, mariadb
@michaelschoenbaechler michaelschoenbaechler marked this pull request as ready for review March 16, 2021 12:20
@AlexMesser AlexMesser merged commit 2dcb493 into typeorm:master Mar 29, 2021
@AlexMesser
Copy link
Collaborator

thank you for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RelationLoader doesn't use transaction
3 participants
@michaelschoenbaechler @AlexMesser @lukinet