Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only first single quote in comments is escaped #7514

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Conversation

AlexMesser
Copy link
Collaborator

Description of change

Fixed column comment escaping for databases that currently supports comment option:

  • PostgreSQL
  • MySQL
  • CockroachDB
  • AuroraDataAPI

Fixes #7479

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • N/A Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@AlexMesser AlexMesser merged commit e1e9423 into master Mar 29, 2021
@AlexMesser AlexMesser deleted the issue-7479 branch March 29, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only first single quote in comments is escaped
1 participant