fix:use host if hostReplicaSet is not provided #7559
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change was for MongoDriver's buildConnectionUrl method for building a connection url for a replica set.
Currently the host that is used is the config option called "hostReplicaSet"
The change updates this so that if this option is not provided it uses a provided "host" with the given port.
It also defaults to using "127.0.0.1" as a host if none is provided, and "27017" if no port was provided.
This change was needed because I did not provide a connection url to my typeorm config, but I provided all other neccessary info to build a connection url. However, I provided only a "host" and not "hostReplicaSet" which caused it to create a url with the host "undefined". I tested this on an environment with a replica set.
Pull-Request Checklist
master
branchnpm run lint
passes with this changenpm run test
passes with this changeFixes #0000