Fix #6867 #7590
Merged
Fix #6867 #7590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* implement the createDatabase, dropDatabase and hasDatabase methods on postgres' query runner Closes #6867
* Set ifNotExist=false when testing with postgres' driver
* Add empty promise return when ifNotExist is true and the specified database already exists on postgres' query runner * Set ifNotExist as true on the database creation and dropping tests
|
thank you for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fixes #6867.
Postgres' database creation and dropping were not implemented and just (silently) resolved an empty promise. As the comment above
createDatabasestated, database creation really isn't allowed inside transaction blocks, but, if a user tries to do that, the query runner should throw an error.Pull-Request Checklist
masterbranchnpm run lintpasses with this changenpm run testpasses with this changeFixes #0000