Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve issue when enum that has functions is used in entity #7653

Merged
merged 1 commit into from
May 15, 2021

Conversation

dariosn85
Copy link
Contributor

Fixes: #7651

Description of change

In case if we are working with enums that contains functions (declaration merging, described in details in issue ticket) corrupted SQLs are generated for migration which leads into failure on the DB side. This fix addresses that issue by filtering out such functions from metadata.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • [N/A] Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@AlexMesser AlexMesser merged commit dba327d into typeorm:master May 15, 2021
@AlexMesser
Copy link
Collaborator

thank you for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enum that contains functions is not accordingly translated to SQL
2 participants