fix: actually return a working ReadStream from SQL Server query runner #7893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imnotjames
force-pushed
the
fix/0000/streaming-verification
branch
from
a5653e9
to
a552d9d
Compare
the sql server query runner wasn't actually returning a ReadStream as expected and there were no tests that confirmed the stream functionality. this corrects both of those problems
imnotjames
force-pushed
the
fix/0000/streaming-verification
branch
from
a552d9d
to
24c0496
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
the sql server query runner wasn't actually returning a ReadStream as expected
and there were no tests that confirmed the stream functionality. this corrects
both of those problems
Pull-Request Checklist
masterbranchnpm run lintpasses with this changenpm run testpasses with this changeFixes #0000