Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module '"typeorm"' has no exported member 'WhereExpression'. #7975

Closed
antonku opened this issue Jul 29, 2021 · 2 comments · Fixed by #7980
Closed

Module '"typeorm"' has no exported member 'WhereExpression'. #7975

antonku opened this issue Jul 29, 2021 · 2 comments · Fixed by #7980

Comments

@antonku
Copy link
Contributor

antonku commented Jul 29, 2021

Issue Description

Expected Behavior

Typeorm exports WhereExpression

Actual Behavior

Typeorm 0.2.34 exports WhereExpression
Typeorm 0.2.35 does not export WhereExpression

So it appears to be a breaking change (at least in typings)

Steps to Reproduce

  1. Import WhereExpression from Typeorm 0.2.35
  2. Try to compile Typescript
  3. See error Module '"typeorm"' has no exported member 'WhereExpression'.

Are you willing to resolve this issue by submitting a Pull Request?

  • ✖️ Yes, I have the time, and I know how to start.
  • ✅ Yes, I have the time, but I don't know how to start. I would need guidance.
  • ✖️ No, I don’t have the time, but I can support (using donations) development.
  • ✖️ No, I don’t have the time and I’m okay to wait for the community / maintainers to resolve this issue.
@antonku
Copy link
Contributor Author

antonku commented Jul 29, 2021

Looks like the root cause is that WhereExpression was renamed to WhereExpressionBuilder in e922f35#diff-2dd5e69a1e67aaf22416147cc9f2cf365b1813006f87147aba08f5dd9178bc3a

So from the consumer side, this can be fixed by importing WhereExpressionBuilder instead of WhereExpression

@imnotjames
Copy link
Contributor

😫 we really shouldn't be exporting literally everything..

I'll make a deprecated alias for where expression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants