Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Do not generate migration for unchanged enum column (#8161) #8164

Merged
merged 1 commit into from Nov 4, 2021
Merged

fix: Do not generate migration for unchanged enum column (#8161) #8164

merged 1 commit into from Nov 4, 2021

Conversation

coyoteecd
Copy link
Contributor

@coyoteecd coyoteecd commented Sep 8, 2021 •
edited

Description of change

Use deep-compare for the enum to detect column schema changes (as done in other places).
Fixes #8161

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@5d-jh 5d-jh mentioned this pull request Sep 23, 2021
Closed
7 tasks
@AlexMesser AlexMesser self-assigned this Nov 4, 2021
@pleerock pleerock merged commit 4638dea into typeorm:master Nov 4, 2021
HeartPattern pushed a commit to HeartPattern/typeorm that referenced this pull request Nov 29, 2021
@coyoteecd @HeartPattern
fix: do not generate migration for unchanged enum column (typeorm#8161)…
822fe88 
… (typeorm#8164)
@coyoteecd coyoteecd deleted the fix-enum-migration branch January 6, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AlexMesser AlexMesser

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@coyoteecd @pleerock @AlexMesser