feat: add support for Postgres 10+ GENERATED ALWAYS AS IDENTITY #8371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoromanovsky
force-pushed
the
lromanovsky/postgres-identity-always
branch
4 times, most recently
from
fb4af30
to
8eebdad
Compare
allow developers to create a Column of identity and choose between `ALWAYS` and `BY DEFAULT`. Closes: typeorm#8370
leoromanovsky
force-pushed
the
lromanovsky/postgres-identity-always
branch
from
fd75a65
to
2425e7e
Compare
|
Thanks for the hard work! |
HeartPattern
pushed a commit
to HeartPattern/typeorm
that referenced
this pull request
Nov 29, 2021
…orm#8371) allow developers to create a Column of identity and choose between `ALWAYS` and `BY DEFAULT`. Closes: typeorm#8370
HeartPattern
pushed a commit
to HeartPattern/typeorm
that referenced
this pull request
Nov 29, 2021
…orm#8371) allow developers to create a Column of identity and choose between `ALWAYS` and `BY DEFAULT`. Closes: typeorm#8370
Any timeframe on getting a new release containing this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow developers to create a generated
PrimaryGeneratedColumnorColumnof identityand choose between
ALWAYSandBY DEFAULT.Relevant documentation: https://www.postgresql.org/docs/10/sql-createtable.html
I am motivated to build on the work in (#7741) and provide both of the supported Postgres 10+ options; arguably using the
ALWAYSoption will be more widely adopted. Additionally expanding the capability to usingidentityon anyColumn, not just primary.Closes: #8370
Description of change
The underlying goal of the PR was to enable
PostgresQueryRunner.tsto be able to decide which of the generated identity types to create.I wanted to add the minimal amount of code to support that.
PrimaryGeneratedColumnIdentityOptionsis needed to be able to pass information not encapsulated by the previously usedUUIDOptionsPull-Request Checklist
masterbranchnpm run lintpasses with this changenpm run testpasses with this changeFixes #0000