You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Typeorm can connect with mysql2 as well as mysql. MysqlConnectionOptions description says Default: 'UTF8_GENERAL_CI'. But I found that mysql2's default charset is UTF8MB4_UNICODE_CI. So This description will confuse to other developer. So, I think that something should change.
Recommended Fix
Please Change description of MysqlConnectionOptions like Default: 'UTF8_GENERAL_CI' -> Default: 'UTF8_GENERAL_CI'(mysql), 'UTF8MB4_UNICODE_CI'(mysql2).
Additional Context
If I was wrong, Please comment about this issue.
Thank you for typeorm maintainers.
Are you willing to resolve this issue by submitting a Pull Request?
Yes, I have the time, but I don't know how to start. I would need guidance.
The text was updated successfully, but these errors were encountered:
What was unclear or otherwise insufficient?
Typeorm can connect with mysql2 as well as mysql.
MysqlConnectionOptions
description saysDefault: 'UTF8_GENERAL_CI'
. But I found that mysql2's default charset isUTF8MB4_UNICODE_CI
. So This description will confuse to other developer. So, I think that something should change.Recommended Fix
Please Change description of
MysqlConnectionOptions
likeDefault: 'UTF8_GENERAL_CI'
->Default: 'UTF8_GENERAL_CI'(mysql), 'UTF8MB4_UNICODE_CI'(mysql2)
.Additional Context
If I was wrong, Please comment about this issue.
Thank you for typeorm maintainers.
Are you willing to resolve this issue by submitting a Pull Request?
Yes, I have the time, but I don't know how to start. I would need guidance.
The text was updated successfully, but these errors were encountered: