Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS]: description of charset at MysqlConnectionOptions is not unclear #9653

Open
0816i opened this issue Dec 23, 2022 · 0 comments
Open

[DOCS]: description of charset at MysqlConnectionOptions is not unclear #9653

0816i opened this issue Dec 23, 2022 · 0 comments

Comments

@0816i
Copy link

0816i commented Dec 23, 2022

What was unclear or otherwise insufficient?

Typeorm can connect with mysql2 as well as mysql. MysqlConnectionOptions description says Default: 'UTF8_GENERAL_CI'. But I found that mysql2's default charset is UTF8MB4_UNICODE_CI. So This description will confuse to other developer. So, I think that something should change.

Recommended Fix

Please Change description of MysqlConnectionOptions like
Default: 'UTF8_GENERAL_CI' -> Default: 'UTF8_GENERAL_CI'(mysql), 'UTF8MB4_UNICODE_CI'(mysql2).

Additional Context

If I was wrong, Please comment about this issue.

Thank you for typeorm maintainers.

Are you willing to resolve this issue by submitting a Pull Request?

Yes, I have the time, but I don't know how to start. I would need guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant