New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LESS 1.4 broke something in the Typeplate LESS port #108

Closed
schilke opened this Issue Jun 10, 2013 · 16 comments

Comments

Projects
None yet
5 participants
@schilke

schilke commented Jun 10, 2013

It looks like that the LESS update broke something in the Typeplate LESS port...:

Cannot read property 'numerator' of undefined
C:\typeplate.less line 346

The related line reads

.modular-scale(@tera, @font-base, @type-scale-unit-value, @measure);

Didn't have the time to dig any deeper at the moment but due to the fact that I haven't changed anything in typeplate.less it's most probably caused by changes in LESS 1.4.

@grayghostvisuals

This comment has been minimized.

Show comment
Hide comment
@grayghostvisuals

grayghostvisuals Jun 11, 2013

Contributor

So unfortunately we won't be supporting LESS going forward making this a situation that can't be fixed. Sorry about that.

Contributor

grayghostvisuals commented Jun 11, 2013

So unfortunately we won't be supporting LESS going forward making this a situation that can't be fixed. Sorry about that.

@schilke

This comment has been minimized.

Show comment
Hide comment
@schilke

schilke Jun 12, 2013

No problem. Just for the reason that someone using the Typeplate Less port stumbles over the issue here: Less changed the "strict math" behaviour but provides a switch as control. Depending on the Less code the solution is to compile with --strict-math=on or not or to change the code appropriately.

See also LESS compile error · Issue #75 · sbspk/Prepros and CSS font shorthand font-size / line-height being divided · Issue #99 · sbspk/Prepros (Your decision if you hint that possible issues on typeplate.com).

Anyway, thanks for responding ;)

schilke commented Jun 12, 2013

No problem. Just for the reason that someone using the Typeplate Less port stumbles over the issue here: Less changed the "strict math" behaviour but provides a switch as control. Depending on the Less code the solution is to compile with --strict-math=on or not or to change the code appropriately.

See also LESS compile error · Issue #75 · sbspk/Prepros and CSS font shorthand font-size / line-height being divided · Issue #99 · sbspk/Prepros (Your decision if you hint that possible issues on typeplate.com).

Anyway, thanks for responding ;)

@jackmcconnell

This comment has been minimized.

Show comment
Hide comment
@jackmcconnell

jackmcconnell Jul 11, 2013

I tried switch strict-math on and off in CodeKit but neither has worked for me. I'm still getting a compile error. Did you ever have any luck with this in the end?

jackmcconnell commented Jul 11, 2013

I tried switch strict-math on and off in CodeKit but neither has worked for me. I'm still getting a compile error. Did you ever have any luck with this in the end?

@schilke

This comment has been minimized.

Show comment
Hide comment
@schilke

schilke Jul 11, 2013

Hm, that's odd, yes I got it working without any errors by turning Strict Math and Strict Units on. The only thing is that I'm not using Codekit but the Open Source App Prepros instead. It really took me some time to find out what went wrong.
What I really don't like is, that Typeplate won't support LESS anymore in the future (already with current version) - luckily Prepros also runs on Windows so I might go the SASS/SCSS way but for current and past projects I'm not really happy with that decision :-/

schilke commented Jul 11, 2013

Hm, that's odd, yes I got it working without any errors by turning Strict Math and Strict Units on. The only thing is that I'm not using Codekit but the Open Source App Prepros instead. It really took me some time to find out what went wrong.
What I really don't like is, that Typeplate won't support LESS anymore in the future (already with current version) - luckily Prepros also runs on Windows so I might go the SASS/SCSS way but for current and past projects I'm not really happy with that decision :-/

@jackmcconnell

This comment has been minimized.

Show comment
Hide comment
@jackmcconnell

jackmcconnell Jul 11, 2013

I worked it out in the end. Switching strict-math in the CodeKit preferences didn't work but doing so on a file-level basis in the main window did. All compiles fine now.

I'm very disappointed in their decision to abandon the LESS port of Typeplate too. SASS/SCSS may be popular but LESS is too. Such a shame.

jackmcconnell commented Jul 11, 2013

I worked it out in the end. Switching strict-math in the CodeKit preferences didn't work but doing so on a file-level basis in the main window did. All compiles fine now.

I'm very disappointed in their decision to abandon the LESS port of Typeplate too. SASS/SCSS may be popular but LESS is too. Such a shame.

@grayghostvisuals

This comment has been minimized.

Show comment
Hide comment
@grayghostvisuals

grayghostvisuals Jul 11, 2013

Contributor

@schilke

What I really don't like is, that Typeplate won't support LESS anymore in the future

@voltronik

I'm very disappointed in their decision to abandon the LESS port of Typeplate too. SASS/SCSS may be popular but LESS is too. Such a shame.

If you both read the last paragraph of our blog post on the v1.1.0 release you will see our reasonings. Also to add to that we feel that if the LESS community really wants the LESS port back they can be the ones to maintain it (nobody has stepped up to the plate as of yet), but going forward we will not maintain multiple ports.

Contributor

grayghostvisuals commented Jul 11, 2013

@schilke

What I really don't like is, that Typeplate won't support LESS anymore in the future

@voltronik

I'm very disappointed in their decision to abandon the LESS port of Typeplate too. SASS/SCSS may be popular but LESS is too. Such a shame.

If you both read the last paragraph of our blog post on the v1.1.0 release you will see our reasonings. Also to add to that we feel that if the LESS community really wants the LESS port back they can be the ones to maintain it (nobody has stepped up to the plate as of yet), but going forward we will not maintain multiple ports.

@jackmcconnell

This comment has been minimized.

Show comment
Hide comment
@jackmcconnell

jackmcconnell Jul 11, 2013

Hadn't seen that, no. Thanks for the update.

jackmcconnell commented Jul 11, 2013

Hadn't seen that, no. Thanks for the update.

@schilke

This comment has been minimized.

Show comment
Hide comment
@schilke

schilke Jul 11, 2013

Oh I did read it and I understand your reasons very well. Plus I'd jump on the train if I find the time. I don't want to look like a git here (LOL no pun intended) but like you said SASS quickly emerged with functionality and that led into less support for LESS everywhere. I'm not a true LESS fan boy but until Subash Pathak came up with Prepros, developers life was not so easy using css precompilers on Windows.
Due to the fact that SASS and LESS also quickly diverged in syntax and functionality, I fear updates and improvements to past projects will become a mess :-/
So actually I've just expressed my personal feelings and won't judge your decision to focus on SASS (and utilize your development ressources more effective) ;-)

schilke commented Jul 11, 2013

Oh I did read it and I understand your reasons very well. Plus I'd jump on the train if I find the time. I don't want to look like a git here (LOL no pun intended) but like you said SASS quickly emerged with functionality and that led into less support for LESS everywhere. I'm not a true LESS fan boy but until Subash Pathak came up with Prepros, developers life was not so easy using css precompilers on Windows.
Due to the fact that SASS and LESS also quickly diverged in syntax and functionality, I fear updates and improvements to past projects will become a mess :-/
So actually I've just expressed my personal feelings and won't judge your decision to focus on SASS (and utilize your development ressources more effective) ;-)

@grayghostvisuals

This comment has been minimized.

Show comment
Hide comment
@grayghostvisuals

grayghostvisuals Jul 11, 2013

Contributor

@schilke

Plus I'd jump on the train if I find the time.

This is mainly the problem with LESS atm. Honestly there are only a few LESSers with the same concerns that you have, but once again nobody is stepping to the plate just voicing their sadness over the removal. Open Source is great when others join in. LESS will exist once again only if those that use LESS preserve it's existence. I invite those that use LESS to make the port and preserve it.

Contributor

grayghostvisuals commented Jul 11, 2013

@schilke

Plus I'd jump on the train if I find the time.

This is mainly the problem with LESS atm. Honestly there are only a few LESSers with the same concerns that you have, but once again nobody is stepping to the plate just voicing their sadness over the removal. Open Source is great when others join in. LESS will exist once again only if those that use LESS preserve it's existence. I invite those that use LESS to make the port and preserve it.

@Cskyleryoung

This comment has been minimized.

Show comment
Hide comment
@Cskyleryoung

Cskyleryoung Jul 15, 2013

@voltronik
Can you please share your method (or a learning resource) for switching strict-math on a file level basis? I'm also using Codekit, and learning how to fix some broken styles. Thanks!

Cskyleryoung commented Jul 15, 2013

@voltronik
Can you please share your method (or a learning resource) for switching strict-math on a file level basis? I'm also using Codekit, and learning how to fix some broken styles. Thanks!

@jackmcconnell

This comment has been minimized.

Show comment
Hide comment
@jackmcconnell

jackmcconnell Jul 16, 2013

Sure.

Open CodeKit and select your project in the left pane. Then click 'Styles' on the right and select the file below that is causing some issue. On the left in the fly-out that appears, it should give you the option to select 'Strict Math' and/or 'Strict Units'. Try these and re-compile using the green button at the bottom.

Hope that helps!

jackmcconnell commented Jul 16, 2013

Sure.

Open CodeKit and select your project in the left pane. Then click 'Styles' on the right and select the file below that is causing some issue. On the left in the fly-out that appears, it should give you the option to select 'Strict Math' and/or 'Strict Units'. Try these and re-compile using the green button at the bottom.

Hope that helps!

@grayghostvisuals

This comment has been minimized.

Show comment
Hide comment
@grayghostvisuals

grayghostvisuals Jul 16, 2013

Contributor

Nice to see both of you helping each other. Internet Hugs <3

Contributor

grayghostvisuals commented Jul 16, 2013

Nice to see both of you helping each other. Internet Hugs <3

@simondahla

This comment has been minimized.

Show comment
Hide comment
@simondahla

simondahla Jul 23, 2013

@grayghostvisuals, I would be interested to take maintaining the LESS port.

simondahla commented Jul 23, 2013

@grayghostvisuals, I would be interested to take maintaining the LESS port.

@grayghostvisuals

This comment has been minimized.

Show comment
Hide comment
@grayghostvisuals

grayghostvisuals Jul 23, 2013

Contributor

@simondahla That would be great. LESS needs to follow the Sass port as closely as possible and when we do updates or releases the LESS port should also follow (this is the part that is tedious and time consuming when multiple ports are offered.)

If you could start a new issue called "LESS Comeback" that would be great so we can discuss specifics before you start. Thanks again 🤘

Contributor

grayghostvisuals commented Jul 23, 2013

@simondahla That would be great. LESS needs to follow the Sass port as closely as possible and when we do updates or releases the LESS port should also follow (this is the part that is tedious and time consuming when multiple ports are offered.)

If you could start a new issue called "LESS Comeback" that would be great so we can discuss specifics before you start. Thanks again 🤘

@simondahla

This comment has been minimized.

Show comment
Hide comment
@simondahla

simondahla Jul 26, 2013

@ grayghostvisuals I will start look at it this weekend!

simondahla commented Jul 26, 2013

@ grayghostvisuals I will start look at it this weekend!

@schilke

This comment has been minimized.

Show comment
Hide comment
@schilke

schilke Jan 28, 2014

@simondahla I guess you didn't get far with it?
I ran into problems again with upgrades - so I just had a look if someone took the time... Guess it's easier to port all the stuff to SASS instead of going both directions...

schilke commented Jan 28, 2014

@simondahla I guess you didn't get far with it?
I ran into problems again with upgrades - so I just had a look if someone took the time... Guess it's easier to port all the stuff to SASS instead of going both directions...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment