-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An in-range update of typescript is breaking the build 🚨 #110
Comments
After pinning to 2.4.0 your tests are passing again. Downgrade this dependency 📌. |
@felixfbecker This is also an issue on the latest version of TypeScript, It's not possible to use pass any class inheriting from |
@felixfbecker I think I found the problem, in many case you use eg. |
I don't understand why that would be a problem with the type system? |
I changed the typings manually and that fixed the problem. Not sure what exactly the issue is but I assume it restricts the to |
@felixfbecker this still makes these typings unusable for latest TS. |
Version 2.4.1 of typescript just got published.
This version is covered by your current version range and after updating it in your project the build failed.
As typescript is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.
I recommend you give this issue a high priority. I’m sure you can resolve this 💪
Status Details
Release Notes
TypeScript 2.4For release notes, check out the release announcement
For new features, check out the What's new in TypeScript 2.4.
For breaking changes, check out the Breaking changes in TypeScript 2.4 page.
For the complete list of fixed issues, check out the fixed issues query for Typescript 2.4.
Download:
Commits
The new version differs by 141 commits.
8b2fe13
Update LKG.
14d95ed
Test:Block-scoped definition of Promise works
a8846bf
Skip block scope check with no error location
44f2336
Merge pull request #16633 from Microsoft/release-2.4_fixIncrementalParsing
4875a27
Add tests
15ef20d
Set the structureReused to be safemoudles when dynamic import change
6d33083
Add tests
11b9f6e
Wip-fix incremental parsing
2721fd4
In TypeScript code, never bind JSDoc normally, just set parent pointers (#16555) (#16561)
0968ed9
Revert string enum changes (#16569)
096f8cc
Update LKG
9241175
Allow running in strict mode (#16557)
f49b007
Update LKG
f1b0f59
Update version to 2.4.1
ed9cde9
Update LKG
There are 141 commits in total.
See the full diff
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴
The text was updated successfully, but these errors were encountered: