Adding an abstract method is a binary compatible evolution. Fix #69 #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bend#69 As stated in Java binary compatibility doc (https://docs.oracle.com/javase/specs/jls/se8/html/jls-13.html), "adding new fields, methods, or constructors to an existing class or interface" is a binary compatible evolution. Adding an abstract method to an interface or class is probably the most surprising binary compatible evolution, but it makes a lot of sense and it's pretty neat. Also, by fixing this problem, we now also fully support Java8 default methods. Which is why this commit also Fix lightbend#68.
dotta
force-pushed
the
issue/69-adding-abstract-method
branch
from
d7974b6
to
e48a091
Compare
|
If I don't hear anything, I'm going to merge this tonight. |
|
Closing this as there are a couple of things I need to verify. Will reopen when it's ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in Java binary compatibility doc
(https://docs.oracle.com/javase/specs/jls/se8/html/jls-13.html),
"adding new fields, methods, or constructors to an existing class or
interface" is a binary compatible evolution.
Adding an abstract method to an interface or class is probably the
most surprising binary compatible evolution, but it makes a lot of sense
and it's pretty neat.
Also, by fixing this problem, we now also fully support Java8 default methods.
Which is why this commit also Fix #68.