Support for backward/forward binary checking #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 16, 2015 14:50
This commit cleans up the Problem case classes, removing mutable state and making the error messages parametric on the affected version. The commit also includes new keys for the sbt plugin, allowing the user to specify the comparison direction, and separate filters for backward and forward checks.
cunei
force-pushed
the
backward-forward
branch
from
f24723f
to
03f0461
Compare
|
this would be useful to have for Scala's own sbt build. (the |
Merged
|
LGTM. Rebasing this on top of current master in #104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds native support for backward/forward/bidirectional binary compatibility checking to MiMa. A single report is generated, with a clear explanation of which side is affected, improving the error reporting of the current Scala build, for example.
The following are included:
mima-backward-issue-filters,mima-forward-issue-filters, andmima-check-direction. The first two can be used to specify problem filters that only apply to the backward or the forward pass, respectively. The existingmima-issue-filtersapplies to both passes, and is prepended to the other two. Themima-check-directionsetting can be set to "backward" (default), "forward", or "both".--backward-filters,--forward-filters, and--direction. The meaning is similar to the three keys above.This pull request needs to be tested and reviewed before merging.