Skip to content
This repository has been archived by the owner on Feb 9, 2019. It is now read-only.

Updated Redis for Scala 2.11 compatibility #125

Merged
merged 2 commits into from
Aug 29, 2014
Merged

Updated Redis for Scala 2.11 compatibility #125

merged 2 commits into from
Aug 29, 2014

Conversation

stephenmuss
Copy link
Contributor

I haven't updated the version from 2.3.0 or any of the other play dependencies. I thought I would leave that for the maintainers to decide.

@lightbend-cla-validator

Hi @stephenmuss,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement:

http://www.typesafe.com/contribute/cla


libraryDependencies ++= Seq(
"com.typesafe.play" %% "play" % "2.3.0" % "provided",
"biz.source_code" % "base64coder" % "2010-12-19",
"com.typesafe.play" %% "play-cache" % "2.3.0",
"com.typesafe.play.plugins" %% "play-plugins-util" % "2.3.0",
"org.sedis" % "sedis_2.10.0" % "1.1.1"
"org.sedis" % "sedis_2.11" % "1.2.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to cross build, you need to not specify the scala version - this will cause the 2.11 version to be used both against 2.10 and 2.11, which is wrong. Instead, use:

"org.sedis" %% "sedis" % "1.2.2"

Then SBT will pick the right version for the right version of Scala when building. To test cross building, run sbt +test (the + means run this command against all configured cross scala versions).

@stephenmuss
Copy link
Contributor Author

Hi @jroper. I've updated build.sbt as per your comment. Thanks for pointing that out.

@jroper
Copy link
Member

jroper commented Aug 29, 2014

Close/opening to trigger travis build.

@jroper jroper closed this Aug 29, 2014
@jroper jroper reopened this Aug 29, 2014
jroper added a commit that referenced this pull request Aug 29, 2014
Updated Redis for Scala 2.11 compatibility
@jroper jroper merged commit 54b54a8 into playframework:master Aug 29, 2014
@stephenmuss stephenmuss deleted the redis-scala-2-11 branch August 29, 2014 05:10
@skylve
Copy link

skylve commented Aug 30, 2014

Hi. Do you know when is this gonna be released on typesafe repo ?

@hossein761
Copy link

Can someone release this!?

@nilswx
Copy link

nilswx commented Oct 7, 2014

Bump. We do need the 2.11 version on the Typesafe repository.

https://github.com/typesafehub/play-plugins/tree/master/redis

^ these instructions get you nowhere with 2.11. Unresolved dependencies everywhere.

@mce
Copy link

mce commented Oct 13, 2014

We resolved this issue by publishing to local or a private repository. I hope typesafe repo is updated soon

git clone https://github.com/typesafehub/play-plugins
cd redis
sbt publish-local

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants