-
-
Notifications
You must be signed in to change notification settings - Fork 161
Updated Redis for Scala 2.11 compatibility #125
Conversation
Hi @stephenmuss, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement: |
|
||
libraryDependencies ++= Seq( | ||
"com.typesafe.play" %% "play" % "2.3.0" % "provided", | ||
"biz.source_code" % "base64coder" % "2010-12-19", | ||
"com.typesafe.play" %% "play-cache" % "2.3.0", | ||
"com.typesafe.play.plugins" %% "play-plugins-util" % "2.3.0", | ||
"org.sedis" % "sedis_2.10.0" % "1.1.1" | ||
"org.sedis" % "sedis_2.11" % "1.2.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to cross build, you need to not specify the scala version - this will cause the 2.11 version to be used both against 2.10 and 2.11, which is wrong. Instead, use:
"org.sedis" %% "sedis" % "1.2.2"
Then SBT will pick the right version for the right version of Scala when building. To test cross building, run sbt +test
(the + means run this command against all configured cross scala versions).
Hi @jroper. I've updated |
Close/opening to trigger travis build. |
Updated Redis for Scala 2.11 compatibility
Hi. Do you know when is this gonna be released on typesafe repo ? |
Can someone release this!? |
Bump. We do need the 2.11 version on the Typesafe repository. https://github.com/typesafehub/play-plugins/tree/master/redis ^ these instructions get you nowhere with 2.11. Unresolved dependencies everywhere. |
We resolved this issue by publishing to local or a private repository. I hope typesafe repo is updated soon
|
I haven't updated the version from
2.3.0
or any of the other play dependencies. I thought I would leave that for the maintainers to decide.