Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use source artifacts that come with update report #306

Closed
wants to merge 1 commit into from
Closed

Use source artifacts that come with update report #306

wants to merge 1 commit into from

Conversation

PanAeon
Copy link

@PanAeon PanAeon commented Dec 7, 2015

This pull request addresses issue #105
When user annotates artifact by withSources() classifier the sources for that artifact will be downloaded during 'update'. So nothing prevents sbteclipse to actually link those already downloaded sources to eclipse libraries.
I have introduced two params - userSetSource and userSetJavadoc that will do exactly that. To minimize any error I have defaulted them to 'false', although I think it is safe enough to make them enabled by default.
I know that use of withSources() classifier is discouraged, although I don't know exact reason. But this use case is somehow useful when user includes large library, like spark, and doesn't want to download all sources transitively.
Personally I'd love to see this feature in sbteclipse.

…hich will link any sources for artifacts annotated with corresponding classifiers
@benmccann
Copy link
Contributor

I'm curious, where are you located and what is your internet connection like? For me downloading all the sources for large projects isn't much of an issue, but it seems like folks have different experiences elsewhere

@PanAeon
Copy link
Author

PanAeon commented May 3, 2016

This is not a big issue for me. Still some times I want to check out
project quickly.
On May 3, 2016 08:26, "Ben McCann" notifications@github.com wrote:

I'm curious, where are you located and what is your internet connection
like? For me downloading all the sources for large projects isn't much of
an issue, but it seems like folks have different experiences elsewhere


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#306 (comment)

@PanAeon PanAeon closed this Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants