Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add a workaround for Redux demo in Prerequisite 4 #47

Closed
dance2die opened this issue Oct 16, 2018 · 3 comments
Closed

Please add a workaround for Redux demo in Prerequisite 4 #47

dance2die opened this issue Oct 16, 2018 · 3 comments

Comments

@dance2die
Copy link
Collaborator

馃 What?

Redux demo in 4. (optional) Read Microsoft's TypeScript-React-Starter docs fails to work as README is out of date.

  1. Failure 1
    Creating a store section - fix in Pull Request.

  2. Failure 2
    Making a container section - Fix in Pull Request.

For the demo program in TypeScript-React-Starter Redux demo to work, either

  1. PR needs to be merged
  2. or need to update the demo manually according to the changes as mentioned above.

馃殌 Suggestion

Please provide users a heads-up when proceeding to go over the prerequisite 4 (optional) Read Microsoft's TypeScript-React-Starter docs.

@swyxio
Copy link
Collaborator

swyxio commented Oct 19, 2018

not sure how to help 馃槄 youre welcome to contribute instructions

@dance2die
Copy link
Collaborator Author

@sw-yx Sure thing 馃榾.
Would you want me to create issues before creating any PRs for subsequent issues?

@swyxio
Copy link
Collaborator

swyxio commented Oct 22, 2018

i decided to keep redux stuff out of the cheatsheet (#48 (comment)). we dont want to document other people's failures here.

@azizhk azizhk closed this as completed Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants