Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React.FunctionComponent or React.PureComponent ? #54

Closed
webmato opened this issue Dec 9, 2018 · 2 comments
Closed

React.FunctionComponent or React.PureComponent ? #54

webmato opened this issue Dec 9, 2018 · 2 comments

Comments

@webmato
Copy link

webmato commented Dec 9, 2018

React.FunctionComponent or React.PureComponent in Section 2: Getting Started / Function Components?

const App: React.FunctionComponent<{ message: string }> = ({ message }) => <div>{message}</div>;

Shouldn't be there

const App: React.PureComponent<{ message: string }> = ({ message }) => <div>{message}</div>;

instead?

@webmato
Copy link
Author

webmato commented Dec 9, 2018

Oh, my bad. React.FunctionComponent is correct of course.

@webmato webmato closed this as completed Dec 9, 2018
@swyxio
Copy link
Collaborator

swyxio commented Dec 9, 2018

still appreciate you filing the question. keep up your journey and file any other issues you find @webmato

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants