Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add as a contributor? #697

Closed
jsjoeio opened this issue Feb 1, 2024 · 7 comments
Closed

add as a contributor? #697

jsjoeio opened this issue Feb 1, 2024 · 7 comments

Comments

@jsjoeio
Copy link
Collaborator

jsjoeio commented Feb 1, 2024

in the old repo, i had contributed a couple docs things.

can i get added as a contributor for docs?

@filiptammergard
Copy link
Collaborator

Hey @jsjoeio! Thanks for contributing in the past. The contributors file here has not been updated in the last four years: https://github.com/typescript-cheatsheets/react/blob/main/CONTRIBUTORS.md

I'm thinking we should either remove that file entirely, or make sure it's updated automatically on new contributors. What do you think @eps1lon?

In any case, you can see the list of contributors here: https://github.com/typescript-cheatsheets/react/graphs/contributors

image

@jsjoeio
Copy link
Collaborator Author

jsjoeio commented Feb 1, 2024

The contributors file here has not been updated in the last four years:

admittedly, i did not check to see when it was last updated 😂 i just saw this on twitter -> saw that there was a CONTRIBUTORS.md started and then opened this!

feel free to just close this as well

@eps1lon
Copy link
Member

eps1lon commented Feb 2, 2024

@all-contributors add @jsjoeio for docs

@all-contributors add @filiptammergard for docs, code

@eps1lon
Copy link
Member

eps1lon commented Feb 2, 2024

@all-contributors add @filiptammergard for docs, code

Copy link
Contributor

@eps1lon

I've put up a pull request to add @jsjoeio! 🎉

I've put up a pull request to add @threepointone! 🎉

Copy link
Contributor

@eps1lon

I've put up a pull request to add @filiptammergard! 🎉

@eps1lon
Copy link
Member

eps1lon commented Feb 2, 2024

Closed in #698

Thank you for the reminder. We just forgot.

@eps1lon eps1lon closed this as completed Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants