Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If a tslint.json doesn't extend from tslint-config-prettier, recommend Prettier #2

Closed
JoshuaKGoldberg opened this issue Jun 24, 2019 · 2 comments · Fixed by #412
Closed

If a tslint.json doesn't extend from tslint-config-prettier, recommend Prettier #2

JoshuaKGoldberg opened this issue Jun 24, 2019 · 2 comments · Fixed by #412
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send in a PR to resolve this! ✨ type: enhancement New feature or request
Milestone
1.0 Ready 🚀

Comments

@JoshuaKGoldberg
Copy link
Member

😄. TSLint maintainers (myself included) have been recommending moving off of whitespace rules for quite some time now. I believe ESLint maintainers are of the same opinion, though it'd be nice to have a source on that.
@JoshuaKGoldberg JoshuaKGoldberg added status: in discussion This issue needs more discussion before code changes type: enhancement New feature or request labels Jun 24, 2019
@JoshuaKGoldberg JoshuaKGoldberg changed the title If a config doesn't (extend|plugin) from (eslint|tslint)-config-prettier, recommend Prettier If a tslint.json doesn't extend from tslint-config-prettier, recommend Prettier Jun 24, 2019
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send in a PR to resolve this! ✨ and removed status: in discussion This issue needs more discussion before code changes labels Jun 24, 2019
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jun 24, 2019
Closed
@JoshuaKGoldberg
Copy link
Member Author

Well this is unfortunate. tslint --print-config doesn't print anything under extends: just an empty array. I'll file an issue on TSLint to talk about improving this.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jul 16, 2019
Closed
@jeremyyap jeremyyap mentioned this issue Oct 17, 2019
Closed
This was referenced Dec 22, 2019
Closed
Closed
@JoshuaKGoldberg JoshuaKGoldberg added this to the 1.0 Ready 🚀 milestone Apr 26, 2020
@JoshuaKGoldberg
Copy link
Member Author

JoshuaKGoldberg commented Apr 26, 2020 •
edited

#348 confirmed this is at least an acceptable opinion for the TSLint and typescript-eslint side. Hooray!

@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Apr 26, 2020
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Apr 26, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send in a PR to resolve this! ✨ type: enhancement New feature or request
Projects
None yet
Milestone
1.0 Ready 🚀
1 participant
@JoshuaKGoldberg