fix space-before-function-paren

[bouzuya]

PR Checklist

• Addresses an existing issue: fixes Configuration for rule "space-before-function-paren" is invalid #292
• That issue was marked as status: accepting prs

Overview

See: #292

[JoshuaKGoldberg]

LGTM, thanks for re-tackling this converter @bouzuya!

If you have time to address the requests soon, that'd be swell - otherwise I can take care of them myself.

[JoshuaKGoldberg]

The contents in the body of this else if are a little substantial to read through. Would you mind splitting them into a separate function? That'd be helpful for readability IMO.

[bouzuya]

I'm sorry. I can't read English well. In this what you mean?

const isObject = (o: unknown): o is Record<string, "always" | "never"> =>
    typeof o === "object" && o !== null;

// ...
} else if (isObject(argument)) {
// ...

Alternatively, I think it would be better to use typeof argument === "undefined" if tslint.json is valid.

// ...
} else if (typeof argument === "undefined") {
    return { rules: [{ ruleName }] };
}
const notices = Object.keys(argument)
    .filter(option => !SUPPORTED_OPTIONS.includes(option))
    .map(option => `Option "${option}" is not supported by ESLint.`);
const filtered = Object.keys(argument)
    .filter(option => SUPPORTED_OPTIONS.includes(option))
    .reduce<Record<string, "always" | "never">>((obj, option) => {
        return { ...obj, [option]: argument[option] };
    }, {});
return {
    rules: [
        {
            ...(notices.length !== 0 && { notices }),
            ...(Object.keys(filtered).length !== 0 && { ruleArguments: [filtered] }),
            ruleName,
        },
    ],
};

What would you like to do specifically?

[JoshuaKGoldberg]

Oh sorry for the ambiguity in my comments! Yes, your second suggestion around using typeof seems great.

My overall goal was to reduce the amount of logic placed inside the else statement, since that can be confusing to read through. Moving that stuff into a separate function can be helpful to split the code up so each individual portion is understandable.

[JoshuaKGoldberg]

As before @bouzuya - I'll apply the discussed changes soon if you don't have the time. Thanks! 🙌

[bouzuya]

Can I ask to fix them?

[JoshuaKGoldberg]

Sure! I'll merge this in now and send a separate PR. Thanks for all your work! 🙌

[JoshuaKGoldberg]

Actually, wait, @bouzuya I think I missed a commit - you applied all the changes I asked for. I think I'm just confusing you unnecessarily. Sorry! 😅