Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-plugin-eslint-config-prettie error #439

Closed
alanhg opened this issue May 1, 2020 · 3 comments · Fixed by #444
Closed

eslint-plugin-eslint-config-prettie error #439

alanhg opened this issue May 1, 2020 · 3 comments · Fixed by #444
Assignees
Labels
status: accepting prs Please, send in a PR to resolve this! ✨ type: bug Something isn't working

Comments

@alanhg
Copy link

alanhg commented May 1, 2020

🐛 Bug Report

  • tslint-to-eslint-config version: 1.0.0-beta
  • ESLint version: 6.8.0
  • Node version: 10.16.0

Actual Behavior

image

Could not import the "eslint-plugin-eslint-config-prettie" module. Do you need to install packages?

I couldn't find eslint-plugin-eslint-config-prettie package on npm

Expected Behavior

replace comment successfuly

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented May 3, 2020

Fascinating. Thanks for the report @alanhg, this looks like it's probably some kind of odd string parsing issue.

eslint-plugin-eslint-config-prettie is missing an r at the end (and might not need eslint-plugin- at the beginning). It should be eslint-config-prettier.

Until this bug gets fixed, you should be able to get around it by deleting your ESLint configuration file (by default, that's .eslintrc.js) before running tslint-to-eslint-config.

@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send in a PR to resolve this! ✨ type: bug Something isn't working labels May 3, 2020
@JoshuaKGoldberg JoshuaKGoldberg added this to the 1.0 Ready 🚀 milestone May 3, 2020
@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented May 3, 2020

Here's the actual error that gets logged:

Error: Command failed: eslint --print-config "./.eslintrc.js"

Oops! Something went wrong! :(

ESLint: 6.8.0.

ESLint couldn't find the plugin "eslint-plugin-eslint-config-prettie".

(The package "eslint-plugin-eslint-config-prettie" was not found when loaded as a Node module from the directory "C:\Code\tslinttest".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

    npm install eslint-plugin-eslint-config-prettie@latest --save-dev

The plugin "eslint-plugin-eslint-config-prettie" was referenced from the config file in ".eslintrc.js".

If you still can't figure out the problem, please stop by https://gitter.im/eslint/eslint to chat with the team.

It reproduces with an .eslintrc.js as simple as:

module.exports = {
  extends: [
    "plugin:eslint-config-prettier",
  ],
};

Two problems:

Switching extends to use "prettier" does fix this issue.

@haarsh24
Copy link

🐛 Bug Report

  • tslint-to-eslint-config version: 1.0.0-beta
  • ESLint version: 6.8.0
  • Node version: 10.16.0

Actual Behavior

image

Could not import the "eslint-plugin-eslint-config-prettie" module. Do you need to install packages?

I couldn't find eslint-plugin-eslint-config-prettie package on npm

Expected Behavior

replace comment successfuly

I'm also getting the same error
Capture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send in a PR to resolve this! ✨ type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants