Skip to content

Commit

Permalink
fix(ts-estree): fix issues with typeParams in FunctionExpression (#208)
Browse files Browse the repository at this point in the history
  • Loading branch information
@armano2 @JamesHenry
armano2 authored and JamesHenry committed Feb 4, 2019
1 parent f513a14 commit d4dfa3b
Show file tree
Hide file tree
Showing 5 changed files with 292 additions and 280 deletions.
252 changes: 126 additions & 126 deletions packages/parser/tests/lib/__snapshots__/typescript.ts.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11047,13 +11047,13 @@ Object {
"line": 2,
},
"start": Object {
"column": 16,
"column": 13,
"line": 2,
},
},
"params": Array [],
"range": Array [
26,
23,
32,
],
"type": "FunctionExpression",
Expand Down Expand Up @@ -11180,13 +11180,13 @@ Object {
"line": 4,
},
"start": Object {
"column": 20,
"column": 17,
"line": 4,
},
},
"params": Array [],
"range": Array [
54,
51,
60,
],
"type": "FunctionExpression",
Expand Down Expand Up @@ -13831,13 +13831,13 @@ Object {
"line": 2,
},
"start": Object {
"column": 11,
"column": 8,
"line": 2,
},
},
"params": Array [],
"range": Array [
23,
20,
28,
],
"type": "FunctionExpression",
Expand Down Expand Up @@ -14260,13 +14260,13 @@ Object {
"line": 2,
},
"start": Object {
"column": 17,
"column": 8,
"line": 2,
},
},
"params": Array [],
"range": Array [
29,
20,
34,
],
"type": "FunctionExpression",
Expand Down Expand Up @@ -16112,13 +16112,13 @@ Object {
"line": 3,
},
"start": Object {
"column": 8,
"column": 5,
"line": 3,
},
},
"params": Array [],
"range": Array [
38,
35,
44,
],
"type": "FunctionExpression",
Expand Down Expand Up @@ -28360,13 +28360,13 @@ Object {
"line": 3,
},
"start": Object {
"column": 18,
"column": 15,
"line": 2,
},
},
"params": Array [],
"range": Array [
28,
25,
44,
],
"returnType": Object {
Expand Down Expand Up @@ -28527,13 +28527,13 @@ Object {
"line": 6,
},
"start": Object {
"column": 20,
"column": 17,
"line": 5,
},
},
"params": Array [],
"range": Array [
66,
63,
82,
],
"returnType": Object {
Expand Down Expand Up @@ -58372,60 +58372,6 @@ Object {
],
"shorthand": false,
"type": "Property",
"typeParameters": Object {
"loc": Object {
"end": Object {
"column": 18,
"line": 2,
},
"start": Object {
"column": 15,
"line": 2,
},
},
"params": Array [
Object {
"loc": Object {
"end": Object {
"column": 17,
"line": 2,
},
"start": Object {
"column": 16,
"line": 2,
},
},
"name": Object {
"loc": Object {
"end": Object {
"column": 17,
"line": 2,
},
"start": Object {
"column": 16,
"line": 2,
},
},
"name": "T",
"range": Array [
30,
31,
],
"type": "Identifier",
},
"range": Array [
30,
31,
],
"type": "TSTypeParameter",
},
],
"range": Array [
29,
32,
],
"type": "TSTypeParameterDeclaration",
},
"value": Object {
"async": false,
"body": Object {
Expand Down Expand Up @@ -58492,13 +58438,13 @@ Object {
"line": 4,
},
"start": Object {
"column": 18,
"column": 15,
"line": 2,
},
},
"params": Array [],
"range": Array [
32,
29,
61,
],
"returnType": Object {
Expand Down Expand Up @@ -58536,6 +58482,60 @@ Object {
},
},
"type": "FunctionExpression",
"typeParameters": Object {
"loc": Object {
"end": Object {
"column": 18,
"line": 2,
},
"start": Object {
"column": 15,
"line": 2,
},
},
"params": Array [
Object {
"loc": Object {
"end": Object {
"column": 17,
"line": 2,
},
"start": Object {
"column": 16,
"line": 2,
},
},
"name": Object {
"loc": Object {
"end": Object {
"column": 17,
"line": 2,
},
"start": Object {
"column": 16,
"line": 2,
},
},
"name": "T",
"range": Array [
30,
31,
],
"type": "Identifier",
},
"range": Array [
30,
31,
],
"type": "TSTypeParameter",
},
],
"range": Array [
29,
32,
],
"type": "TSTypeParameterDeclaration",
},
},
},
Object {
Expand Down Expand Up @@ -58576,60 +58576,6 @@ Object {
],
"shorthand": false,
"type": "Property",
"typeParameters": Object {
"loc": Object {
"end": Object {
"column": 8,
"line": 5,
},
"start": Object {
"column": 5,
"line": 5,
},
},
"params": Array [
Object {
"loc": Object {
"end": Object {
"column": 7,
"line": 5,
},
"start": Object {
"column": 6,
"line": 5,
},
},
"name": Object {
"loc": Object {
"end": Object {
"column": 7,
"line": 5,
},
"start": Object {
"column": 6,
"line": 5,
},
},
"name": "T",
"range": Array [
69,
70,
],
"type": "Identifier",
},
"range": Array [
69,
70,
],
"type": "TSTypeParameter",
},
],
"range": Array [
68,
71,
],
"type": "TSTypeParameterDeclaration",
},
"value": Object {
"async": false,
"body": Object {
Expand Down Expand Up @@ -58696,13 +58642,13 @@ Object {
"line": 7,
},
"start": Object {
"column": 8,
"column": 5,
"line": 5,
},
},
"params": Array [],
"range": Array [
71,
68,
100,
],
"returnType": Object {
Expand Down Expand Up @@ -58740,6 +58686,60 @@ Object {
},
},
"type": "FunctionExpression",
"typeParameters": Object {
"loc": Object {
"end": Object {
"column": 8,
"line": 5,
},
"start": Object {
"column": 5,
"line": 5,
},
},
"params": Array [
Object {
"loc": Object {
"end": Object {
"column": 7,
"line": 5,
},
"start": Object {
"column": 6,
"line": 5,
},
},
"name": Object {
"loc": Object {
"end": Object {
"column": 7,
"line": 5,
},
"start": Object {
"column": 6,
"line": 5,
},
},
"name": "T",
"range": Array [
69,
70,
],
"type": "Identifier",
},
"range": Array [
69,
70,
],
"type": "TSTypeParameter",
},
],
"range": Array [
68,
71,
],
"type": "TSTypeParameterDeclaration",
},
},
},
Object {
Expand Down
Loading

0 comments on commit d4dfa3b

Please sign in to comment.