fix(typescript-estree): correct parenthesized optional chain AST

[bradzacher]

Fixes #1139

Also fixes the package not working in the browser (ts.sys === undefined in the browser).

The snapshots are getting pretty ugly now.
I think we need a new system for them (#1142).

I tested this via a local build of ASTExplorer.
Sidebar - we should really maintain our own version of it (#1143).

[typescript-eslint]

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[codecov]

Codecov Report

Merging #1141 into master will decrease coverage by 0.03%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##           master    #1141      +/-   ##
==========================================
- Coverage   94.07%   94.03%   -0.04%     
==========================================
  Files         120      120              
  Lines        5214     5217       +3     
  Branches     1443     1445       +2     
==========================================
+ Hits         4905     4906       +1     
  Misses        177      177              
- Partials      132      134       +2

Impacted Files	Coverage Δ
packages/typescript-estree/src/convert.ts	98.99% <100%> (ø)	⬆️
...ges/typescript-estree/src/create-program/shared.ts	75% <50%> (-5%)	⬇️
packages/typescript-estree/src/parser.ts	94.82% <87.5%> (-0.79%)	⬇️

[thorn0]

Please update also SUPPORTED_TYPESCRIPT_VERSIONS. It doesn't include 3.7.1-rc.

[thorn0]

warnAboutTSVersion also fails in the browser because of process.stdout.isTTY.

[thorn0]

In Prettier's build configuration, we have process, but not process.stdout. 🤷‍♂️

[bradzacher]

darn...

probably just better to do what parser does, and clear the logger function:

typescript-eslint/packages/parser/src/parser.ts

Lines 87 to 93 in d4703e1

	const warnOnUnsupportedTypeScriptVersion = validateBoolean(
	options.warnOnUnsupportedTypeScriptVersion,
	true,
	);
	if (!warnOnUnsupportedTypeScriptVersion) {
	parserOptions.loggerFn = false;
	}

(note that this logger function isn't used anywhere else, it's only used to log the warning)