fix(typescript-estree): fix range of assignment in parameter #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armano2
added
bug
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
==========================================
+ Coverage 95% 95.01% +<.01%
==========================================
Files 48 48
Lines 2484 2487 +3
Branches 381 382 +1
==========================================
+ Hits 2360 2363 +3
Misses 75 75
Partials 49 49
|
JamesHenry
approved these changes
Jan 22, 2019
armanio123
pushed a commit
to armanio123/typescript-eslint
that referenced
this pull request
Jan 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with modifiers range beeing included into
AssignmentPatternin parameter propertymodifiers in this case are attached to
TSParameterProperty#114 (comment)