feat(parser): handle optional chaining in scope analysis

[Nizarius]

Fixes #1090
Fixes #1116
Fixes #1104

[typescript-eslint]

Thanks for the PR, @Nizarius!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[codecov]

Codecov Report

Merging #1169 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1169      +/-   ##
==========================================
+ Coverage   93.96%   93.96%   +<.01%     
==========================================
  Files         120      120              
  Lines        5201     5207       +6     
  Branches     1442     1443       +1     
==========================================
+ Hits         4887     4893       +6     
  Misses        179      179              
  Partials      135      135

Impacted Files	Coverage Δ
packages/parser/src/analyze-scope.ts	95.5% <100%> (+0.1%)	⬆️

[Nizarius]

Guys, can you please give me any update on this PR? It looks like crucial bug but in 4 days no comments (or merging) were provided.

[bradzacher]

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Myself and the other maintainers volunteer our time to this project. We do not always have time every week to review PRs.

We'll get to it as soon as we can.

[bradzacher]

mostly LGTM.

A few comments.

Also (similar to #1175) could you please add more test cases across every one of these rules?

Fixture examples for cases to ensure are handled correctly:
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/shared-fixtures/fixtures/typescript/basics/optional-chain-call-with-parens.src.ts
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/shared-fixtures/fixtures/typescript/basics/optional-chain-call.src.ts
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/shared-fixtures/fixtures/typescript/basics/optional-chain-element-access-with-parens.src.ts
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/shared-fixtures/fixtures/typescript/basics/optional-chain-element-access.src.ts
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/shared-fixtures/fixtures/typescript/basics/optional-chain-with-parens.src.ts
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/shared-fixtures/fixtures/typescript/basics/optional-chain.src.ts

[Nizarius]

@bradzacher I've added optionalCallExpression to Referencer and added a lot of new tests to these rules

[bradzacher]

@deser and @xwchris - please don't comment with comments like that.
It serves no purpose, and just creates spam notifications for everyone (i.e. for myself and the other maintainers, or anyone watching this repo).

Let me be clear: it doesn't bump the priority, it just spams people.

As I mentioned before, this project is maintained by volunteers. We will get to a review when we're able.

[bradzacher]

LGTM!
Thanks for doing this.

[davidje13]

Using the just-published 2.7.0 (which was released after this patch) I'm still seeing "no-restricted-globals" and "@typescript-eslint/no-use-before-define" errors when using ?. syntax. (#1090 #1104). Is it possible this patch somehow got missed from the released build? I haven't done much investigating yet.

Edit: looks like the code added in this PR is present in the build I'm using. I'm going to investigate further.

Edit2: My issue was due to a .eslintcache file (--cache in the eslint command). Removing that makes it work perfectly when running 2.7.0 :)